Add optional math support for markdown #2708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: port zola release build to gh actions & support linux arm64 Signed-off-by: Henrik Gerdes <[email protected]> * fix: add buildx support for multi-arch docker images Signed-off-by: Henrik Gerdes <[email protected]> * fix: pin gh release action to sha & allow pre-releases Signed-off-by: Henrik Gerdes <[email protected]> * fix: use env in gh action for linux arm build Signed-off-by: Henrik Gerdes <[email protected]> * chore: switch to dtolnay/rust-toolchain action for rust setup Signed-off-by: Henrik Gerdes <[email protected]> * fix: windows archive step Signed-off-by: Henrik Gerdes <[email protected]> --------- Signed-off-by: Henrik Gerdes <[email protected]>
Signed-off-by: xixishidibei <[email protected]>
Having a crate depend on files outside of its directory breaks building Zola as a dependency using Nix
* Add pagination info to get_section * Add documentation for pagination information * Stick to section properties `paginated` attributes removed
…nt (getzola#2688) This adds semantic meaning to the footnotes organization and improves accessibility by aiding disabled users who rely on assistive devices such as screen readers which utilize semantic tags such as the footer element in order to navigate properly. The hr element is semantically defined as representing a paragraph-level thematic break. Now that the footnotes are descendants of the footer element, the hr element originally preceding the footnotes list is no longer necessary (footnotes are no longer paragraph-level content) and thus replaced. However, the footer element is given the class "footnotes" to allow for styling, so the following CSS could be used to provide a stylistically equivalent visible border separating the footnotes from the content if so desired: .footnotes { border-top: 2px groove gray; } Test snapshots are also updated to reflect the new footer elements.
recmo
force-pushed
the
recmo/enable-math
branch
from
a52418a to
b513f1f
Compare
Keats
requested changes
Nov 18, 2024
| @@ -45,6 +45,8 @@ pub struct Markdown { | |||
| pub external_links_no_referrer: bool, | |||
| /// Whether smart punctuation is enabled (changing quotes, dashes, dots etc in their typographic form) | |||
| pub smart_punctuation: bool, | |||
| /// Whether to enable latex math rendering | |||
| pub math: bool, | |||
There was a problem hiding this comment.
We want that to be an enum. Eventually (hopefully) there will be math rendering inside Zola (eg https://zola.discourse.group/t/a-simpler-katex-alternative-that-works-today/2156/3) so we will want to support classes/pre-render etc
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one:
This fixes #2019 without adding substantial complexity or dependencies. It optionally enables a common-mark extension available in
pulldown-cmark.This will correctly parse delimited math, and render html like
<span class="math math-inline">\sum_i x_i<\span>.To render the latex using Katex, include something like this in the header: